search

mclemente / fvtt-module-polyglot

Talk to others using a language you can speak and scrambles text you can't understand.
MIT License
40 stars 47 forks source link

polyglot 2.3.13 and midi qol 11.1.8 misbehave together #333

Closed miromonti closed 8 months ago

miromonti commented 8 months ago

With only these six modules operating... Screen Shot 2023-10-29 at 1 41 23 AM

...This error appears whenever a token is selected: Screen Shot 2023-10-29 at 1 09 38 AM

Find the Culprit helped determine that Midi QOL and Polyglot are the cause.

Nothing bad happens at first. But eventually, the game lags. Symptoms include players' rolls take a long time to appear, the game seems to freeze, clicking a different token (as a GM) doesn't happen (perhaps taking too long to happen), and browser refresh just doesn't. (Again, perhaps taking too long to happen; I didn't bother to wait further.)

Expected behavior Seamless interaction and no error.

Additional context I recognize the issue might be Midi QOL. But as they have 213 issues and Polyglot has 9 (not counting this one), I figure the problem might be realized here sooner.

mclemente commented 8 months ago

If you're using Find the Culprit you need to keep disabling modules until it stops throwing errors.

If you disabled Midi Qol it would've stopped throwing errors and it would show this: image

This isn't a Polyglot issue. You have messages sent by a deleted user and that's what is breaking Midi.

I recognize the issue might be Midi QOL. But as they have 213 issues and Polyglot has 9 (not counting this one), I figure the problem might be realized here sooner.

That's not how this works.

miromonti commented 8 months ago

Thanks for Polyglot. I presented the issue to Midi QOL and added your response.