search

mclemente / fvtt-module-polyglot

Talk to others using a language you can speak and scrambles text you can't understand.
MIT License
41 stars 48 forks source link

[Bug] Unable to save Font Settings #343

Closed EinWaterBottle closed 10 months ago

EinWaterBottle commented 10 months ago

Describe the bug Polyglot Font Settings are not saving, specifically the "Logographical" and "Only Alphabetic" checkboxes. "Font Size" at least seems to be able to be altered without issue.

To Reproduce Steps to reproduce the behavior:

  1. Open Font Settings under Polyglot module settings.
  2. Check or uncheck "Logographical" or "Only Alphabetic" checkboxes.
  3. Save settings
  4. Reload page as instructed by Foundry
  5. See error.

Expected behavior I expect the settings to be altered and stay altered.

Screenshots chrome_CfKT3xQWGv

Additional context I believe the "Logographical" and "Only Alphabetic" checkboxes actually clear themselves rather than not being changed.

In testing, I deactivated every module to find possible incompatibilities. The issue remains even with only this module active.

mclemente commented 10 months ago

I've tried to reproduce this on a new world and couldn't get to reproduce it, the checkboxes saved correctly. Could you try this on a new world?

Do you have any additional fonts? How are you hosting the game?

EinWaterBottle commented 10 months ago

I run servers via Forge, and run only the fonts Polyglot and core Foundry provide.

  1. I created a new world as you said and tried reproducing the same issue. This time, however, it saved. So it's likely the default settings work.
  2. Then, I messed around with some of the General Settings. I activated "Add Foundry's fonts of Font Settings" and "Add Polyglot's fonts to Core", restarted, and found the Font Settings checkboxes had all cleared.
  3. Next, I deactivated those two settings and messed around with Font Settings checkboxes, which were applying correctly.
  4. This time, I activated only "Add Foundry's fonts of Font Settings". The checkboxes were applying correctly.
  5. Then I activated only "Add Polyglot's fonts to Core". The checkboxes were applying correctly too.
  6. I activated both. The checkboxes were now clearing like before.

So I assume from my testing it's those two settings being active together that's causing the issue. Which is an easy solution for me, since I'll just toggle off one of those settings in my home server, but it's still something that should be brought to your attention.

Update: I went to my original home server and deactivated "Add Polyglot's fonts to Core". Everything works alright for me now.

mclemente commented 10 months ago

Thank you for pinpointing it. That was a nasty bug, it should be fixed now. Let me know if you run into any issues.