search

mclemente / fvtt-module-polyglot

Talk to others using a language you can speak and scrambles text you can't understand.
MIT License
41 stars 48 forks source link

Custom Languages not showing in language proficiency #370

Closed maxobremer closed 4 months ago

maxobremer commented 4 months ago

What happened?

When adding custom languages they arent available when adding language proficiency

Reproduction Steps

Open up your fav test world and have only polyglot enabled module wise

  1. In polyglot's general settings go to languages
  2. Add some custom languages
  3. (optional) remove system languages
  4. save changes
  5. open a character sheet
  6. try to add a language and non are added

image

Which game system, and which version, are you using?

dnd5e 3.1.2

Which Polyglot version are you using?

2.4.9

mclemente commented 4 months ago

I couldn't reproduce the bug.

image

mclemente commented 4 months ago

Are there any errors on the console?

maxobremer commented 4 months ago

Got this error and these warnings image image

this was in a test world (Test) i have used a couple of times. Just for the double made another test world (Test 2) and there it did work? Im guessing something is leftover or something from old tests in the original test world? Both had only polyglot enabled

mclemente commented 4 months ago

Could you input saveDataToFile(JSON.stringify(game.settings.get("polyglot", "Alphabets"), null, 2), "text/json", "polyglot-alphabets.json") into the console and upload the file over here? It will export the module's setting. Last time I've spotted that bug I forgot to ask for the setting so I could try fixing it.

As for the actual fix, follow the instructions here https://github.com/mclemente/fvtt-module-polyglot/issues/364#issuecomment-1986953207

maxobremer commented 4 months ago

Currently travelling home but if my Internet provider has fixed shit in their end I will do what you asked in about 2 hours, else I will do it tomorrow when I know stuff will be fixed.

maxobremer commented 4 months ago

Here you go, this is from my test world polyglot-alphabets.json

followed your guide to fix the issue and that worked for both the test and my normal game world. Thanks for the help. Do you need anything from me or is this a one time issue and as such this threat should be closed or not?

mclemente commented 4 months ago

Here you go, this is from my test world polyglot-alphabets.json

Thank you for providing the old file, that did it for me.

followed your guide to fix the issue and that worked for both the test and my normal game world. Thanks for the help.

You're welcome. I should've been more careful back when I made changes to the settings. I'm sorry for your troubles.

Do you need anything from me or is this a one time issue and as such this threat should be closed or not?

It was a one time thing, I'll release an update to make sure nobody else gets affected by this bug.