search

mclemente / fvtt-module-polyglot

Talk to others using a language you can speak and scrambles text you can't understand.
MIT License
41 stars 48 forks source link

[Pathfinder 1e] Custom languages are not being loaded #396

Closed LeCuay closed 1 month ago

LeCuay commented 1 month ago

What happened?

When loading the total of languages, the custom ones are omitted.

Note: this is most likely because traits.languages.total and traits.languages.customTotal need to be merged in the loading.

Reproduction Steps

1) Add a custom language to an NPC. 2) See if the custom language is part of languages selector.

You'll see it isn't displayed.

imagen

Which game system, and which version, are you using?

pf1 10.7

Which Polyglot version are you using?

2.4.10.2

mkahvi commented 1 month ago

This can be seen as an issue in the system itself for not including custom languages in .total

Edit: Looking into the code, it seems the customTotal needs to exist separately for some special handling.

This module should combine the two, the special handling the system needs is irrelevant here.

LeCuay commented 1 month ago

This can be seen as an issue in the system itself for not including custom languages in .total

Edit: Looking into the code, it seems the customTotal needs to exist separately for some special handling.

This module should combine the two, the special handling the system needs is irrelevant here.

Seems to be here already, just not working (?)

LeCuay commented 1 month ago

Nevermind it is working, is just not displayed without selecting the character