mclemente / healthEstimate

See the state of a character's health with a simple mouse-hover.
MIT License
22 stars 34 forks source link

Missing organic type for SFRPG #220

Closed danimrath closed 10 months ago

danimrath commented 12 months ago

Describe the bug When deciding to list an actor as dead or just unconscious in Starfinder NPC's are only reporting as unconscious regardless of the settings.

To Reproduce Steps to reproduce the behavior:

  1. Set NPCs die immediately setting to true
  2. set NPC health to 0 in Starfinder and see unconscious

Expected behavior The NPC should show as Dead

Game Specifics (please complete the following information):

Additional context isDead function is returning isOrganicType && (isNPCJustDie || isShowDead || isDefeated || isFlaggedDead); However the isOrganicType does not have an entry listed for the SFRPG specific npc2 type. I already tested adding npc2 to the base organic types and it works to fix the issue. Just didn't know how you wanted to handle it.