search

mclements / Splines2.jl

Spline bases for regression modelling in Julia
MIT License
12 stars 5 forks source link

replace Int32 with Int #1

Closed kleinschmidt closed 4 years ago

kleinschmidt commented 4 years ago

Int is aliased to the "native" integer type on the system (Int32 on a 32 bit system and Int64 on a 64 bit system). Specifying Int32 everywhere means that any "naked" integer passed as a parameter to these functions on a 64 bit system results in an error.

mclements commented 4 years ago

Thank you for this very helpful pull request, which I have accepted in toto.

Any other suggestions for how to make the code more idiomatic would also be appreciated.

Sincerely, Mark.