mclements / rstpm2

An R package for generalised survival models
28 stars 11 forks source link

Define STRICT_R_HEADERS in Makevars*, include cfloat for DBL_EPSILON #20

Closed eddelbuettel closed 3 years ago

eddelbuettel commented 3 years ago

Dear Mark, dear rstpm2 team,

Your CRAN package rstpm2 uses Rcpp, and is affected if we add a definition of STRICT_R_HEADERS as we would like to do. Please see the discussion at https://github.com/RcppCore/Rcpp/issues/1158 and the links therein for more context on this.

Here instead of prefixing each #include with STRICT_R_HEADERS we define it once in src/Makevars, and include cfloat (or float.h, C style) in one file so that DBL_MAX is defined. No other changes were made.

It would be lovely if you could apply this. There is no strong urgency: we aim to get this done over all affected packages in the space of a few months. If you apply it, would you mind dropping me a note by email or swinging by https://github.com/RcppCore/Rcpp/issues/1158 to confirm?

Many thanks for your help, and I hope you continue to find Rcpp helpful. Please don't hesitate to ask if you have any questions.