mclintprojects / actioncable-vue

A Vue plugin that makes integrating Rails Action Cable dead-easy.
MIT License
182 stars 37 forks source link

TypeScript definition for connected and disconnected seem wrong #75

Closed liayn closed 2 months ago

liayn commented 1 year ago

The type definitions for $cable.connected and $cable.disconnected are wrong in the sense those properties do not seem to actually exist. At least I couldn't find a word within the src folder.

https://github.com/mclintprojects/actioncable-vue/blob/ac1c863adcbad71ade12cd6521778c8cc4ccf804/types/vue.d.ts#L18

I guess those two can be removed and it would save some working hours searching why "connected" is never true.