mcmancini / UkWofost

Implementation of the WOFOST crop yield model to simulate crop yields in the UK
https://netzeroplus.ac.uk/
1 stars 0 forks source link

Fix solar radiation in weather data providers #40

Closed mcmancini closed 5 months ago

mcmancini commented 5 months ago

WOFOST requires as an input IRRAD which is downward shortwave radiation. This is dealt with correctly in the NASA weather data provider, but it is not in the ParcelWeatherDataProvider (need to check in the NetCDFWeatherDataProvider). The ParcelWeatherDataProvider can take either csv files from Ilya and Jon (downscaled weather from UKCP18 for each parcel in the UK) or ERA5 reanalysis data downloaded from Copernicus using the ERA 5 Weather downloader which I created to retrieve historic weather data for calibration purposes. While the ERA5 data contains already a column for "IRRAD" as required by WOFOST, that is not the case for the downscaled data. Make sure that the weather data provider for parcels can deal with both data sources!

mcmancini commented 5 months ago

Addressed with PR https://github.com/mcmancini/UkWofost/pull/44