search

mcmero / SVclone

A computational method for inferring the cancer cell fraction of tumour structural variation from whole-genome sequencing data.
BSD 3-Clause "New" or "Revised" License
40 stars 10 forks source link

error in file path for writing post-assign pdf #26

Closed anoronh4 closed 1 year ago

anoronh4 commented 1 year ago

I found what i believe to be a bug in the following lines: https://github.com/mcmero/SVclone/blob/4a02d5e2d8f548b2f38e9f7f77ea432bf456b349/SVclone/post_assign.R#L172 https://github.com/mcmero/SVclone/blob/4a02d5e2d8f548b2f38e9f7f77ea432bf456b349/SVclone/post_assign.R#L175 which results in the files being written to:

mysample/ccube_out/post_assignmysample_ccube_postAssign_sv_results.RData
mysample/ccube_out/post_assignmysample_ccube_sv_postAssign_results.pdf

rather than

mysample/ccube_out/post_assign/mysample_ccube_postAssign_sv_results.RData
mysample/ccube_out/post_assign/mysample_ccube_sv_postAssign_results.pdf

should be a simple change, just switching to fn = paste0(resultFolder, "/", sample, "_ccube_sv_postAssign_results.pdf")) for example