search

mcmilk / 7-Zip-zstd

7-Zip with support for Brotli, Fast-LZMA2, Lizard, LZ4, LZ5 and Zstandard
https://mcmilk.de/projects/7-Zip-zstd/
Other
5.06k stars 300 forks source link

crlf in git attributes #285

Closed tansy closed 1 year ago

tansy commented 1 year ago

Hello, you have made most of the files auto in .gitattributes making them use LF line ending in *nix, which I totally agree and support. You also marked whole bunch of files as CRLF and quite unnecessarily. All but .dsp and .dsw don't need to be 'converted' to CRLF. I have tested all of them and they all work without it. Only, as said before .dsp/.dsw must be kept in DOS fashion or they refuse to work. If you are a purist you can keep .bat/.cmd as well, although they will work with LF anyways. It's just a remark and suggestion to remove them from CRLF section and make it clearer. Regards

mcmilk commented 1 year ago

Okay, I leave all extensoins to their current values... but change the .rc also to LF. Thanks for the provided info.