search

mcmilk / 7-Zip-zstd

7-Zip with support for Brotli, Fast-LZMA2, Lizard, LZ4, LZ5 and Zstandard
https://mcmilk.de/projects/7-Zip-zstd/
Other
4.87k stars 293 forks source link

"Cannot find archive name" error while trying to extract through context menu #312

Closed akuropka closed 1 year ago

akuropka commented 1 year ago

OS Version: Microsoft Windows 11 [10.0.22624.1537] Program Version: 7-Zip ZS 22.01 - v1.5.5 - Release 1 [v22.01-v1.5.5-R1]

I've updated 7-Zip-zstd today using official release and noticed that I cannot extract archives directly from the context menu anymore. It works with earlier releases. I am using the classic context menu in Windows 11. Opening archives (including from context menu) and extracting still works.

I guess it's related to PR https://github.com/mcmilk/7-Zip-zstd/pull/307.

See also Issue https://github.com/mcmilk/7-Zip-zstd/issues/309 raised by @rainbowsource.

20230405_164448_7zG

mcmilk commented 1 year ago

Have you restartet after upgrade? If not, please do this.

akuropka commented 1 year ago

Just done but issue still exists.

rainbowsource commented 1 year ago

Hmmm... It does appear that this is a problem. 😄

Hermholtz commented 1 year ago

Just rebooted, it did not fix the issue for me. I just wanted to unpack TotalCmd.7z, so it's not the issue of some weird characters in archive name.

image

mcmilk commented 1 year ago

Yes, I will remove the cmdline fix of @sebres for now ....

Hermholtz commented 1 year ago

Thank you Tino! 🙏

mcmilk commented 1 year ago

Could someone try, if the fresh build binaries are working correctly?

You can get them here: https://github.com/mcmilk/7-Zip-zstd/actions/runs/4621050244 They are within the zip file ...

sebres commented 1 year ago

Hmm... I didn't think about possibly "wrong" invocation from UI (I thought it uses DDE/library and not exe-call directly)... Since it is something about Extract to "Path\" may be the cmd-line built from be menu looks like this?

7z x ... archive.7z "Path\"

the correct command line after fix #307 would be surely that:

- 7z x ... archive.7z "Path\"
+ 7z x ... archive.7z "Path\\"
akuropka commented 1 year ago

Could someone try, if the fresh build binaries are working correctly?

👍 works

mcmilk commented 1 year ago

@sebres - I will just release the working stuff ... but we should fix the cmdline parsing also with some later pull request ... but easy going, no need to do it fast I think ;-)

akuropka commented 1 year ago

@mcmilk, @sebres, thank you to you both for your efforts.

sebres commented 1 year ago

I'm surprised how it could work (on another platforms than _WIN32) if I look at code like this: https://github.com/mcmilk/7-Zip-zstd/blob/d94284915adee41e04d229af657931b2f9b2a4fc/CPP/7zip/UI/Console/MainAr.cpp#L59-L64 (where the arguments are used directly from main parsed using default notation)

sebres commented 1 year ago

Just for the record - #313 must fix this for new cmd-line parsing algorithm (windows default notation).