search

mcmilk / zstdmt

Multithreading Library for Brotli, Lizard, LZ4, LZ5, Snappy and Zstandard
Other
181 stars 33 forks source link

safer compile?! #2

Closed 2i3r closed 7 years ago

2i3r commented 7 years ago

1- Failed to compile (gcc_fails.txt) on "xubuntu 4.4.0-31-generic SMP i686" and "gcc (Ubuntu 5.4.0-6ubuntu1~16.04.4) 5.4.0 20160609" with "Undefined reference to " all ZSTD_XXXX reference functions. Found a solution in: http://stackoverflow.com/questions/10456581/undefined-reference-to-symbol-even-when-nm-indicates-that-this-symbol-is-present by moving linker -lXXX to the end of compile line, problem solved on this case.

2- Adding Header Guard to "util.h" just seemed to be useful, as it's double defined in both "util.c" and "zstdmt.c"/"lz4mt.c"/"lz5mt.c".

Thanks for this great work, really useful to me.

mcmilk commented 7 years ago

Thanks for the hint... yes, some systems have problems, when the linker options are not in the end...