Closed jinfeihan57 closed 4 years ago
mcmilk
commented
4 years ago Not really, but if yu want snappy within zstdmt - no problem. I would take some RP, I could also do some programming for that.... what do you mean with "And I made snappy multithreading." ?
jinfeihan57
commented
4 years ago RP？Do you mean PR ? I can submit PR.
ghost
commented
4 years ago @jinfeihan57 You can explain "snappy multithreading" in Chinese and I will be happy to help you translate your words (comment) to English. (你可以用中文解释 "snappy multithreading" 的意思。我乐意把你的留言翻译成英文。)
jinfeihan57
commented
4 years ago @ipaucek4680 snappy算法多线程 I'm working on it. It's will be finished this weekend.（我正在编写snappy的多线程，计划这周末完成。）
ghost
commented
4 years ago @mcmilk I believe he is referring to the compression library called "Snappy". He is working on implementing the multi-threading support of the Snappy library and would like to see if it can be merged into this repository. The work will be finished this weekend.
jinfeihan57
commented
4 years ago add snappy delete lz5 update zstd @mcmilk @ipaucek4680 https://github.com/mcmilk/zstdmt/pull/7 https://github.com/jinfeihan57/zstdmt
mcmilk
commented
4 years ago @jinfeihan57 - yes, I meant pull request :-)
It's nice that you created a PR, but please adjust the code: C++ -> C ... And leave LZ5 there, but we may mark it obsolete - that would be nice I think.
jinfeihan57
commented
4 years ago I have restored lz5.
mcmilk
commented
4 years ago Thank you, it's there for reference ... and also 7-Zip ZS uses this lib, and a want to leave it there also.
mcmilk
commented
4 years ago Snappy is included now.
I will check the new code later, it was just merged without checks ;-)
mcmilk
commented
4 years ago I have rebased the commits today a bit ... and moved the github tests into the Makefile
Are there plans to add compression algorithms? I want to help. And I made snappy multithreading.