Closed DenisJ9798 closed 5 years ago
Please test with latest builds: https://ci.citizensnpcs.co/job/Sentinel/ That issue may have already been fixed. If it hasn't been, I'll need the error message as it appears on the current build.
[13:03:27 ERROR]: Could not pass event EntityDamageByEntityEvent to Sentinel v1.9.2 (build 260) org.bukkit.event.EventException: null at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[Spigot.jar:git-Spigot-e8ded36-acbc348] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[Spigot.jar:git-Spigot-e8ded36-acbc348] at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:500) [Spigot.jar:git-Spigot-e8ded36-acbc348] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:485) [Spigot.jar:git-Spigot-e8ded36-acbc348] at org.bukkit.craftbukkit.v1_12_R1.event.CraftEventFactory.callEvent(CraftEventFactory.java:93) [Spigot.jar:git-Spigot-e8ded36-acbc348] at org.bukkit.craftbukkit.v1_12_R1.event.CraftEventFactory.callEntityDamageEvent(CraftEventFactory.java:580) [Spigot.jar:git-Spigot-e8ded36-acbc348] at org.bukkit.craftbukkit.v1_12_R1.event.CraftEventFactory.handleEntityDamageEvent(CraftEventFactory.java:483) [Spigot.jar:git-Spigot-e8ded36-acbc348] at org.bukkit.craftbukkit.v1_12_R1.event.CraftEventFactory.handleLivingEntityDamageEvent(CraftEventFactory.java:612) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.EntityLiving.damageEntity0(EntityLiving.java:1346) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.EntityHuman.damageEntity0(EntityHuman.java:846) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.EntityLiving.damageEntity(EntityLiving.java:868) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.EntityHuman.damageEntity(EntityHuman.java:759) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.EntityPlayer.damageEntity(EntityPlayer.java:586) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.citizensnpcs.nms.v1_12_R1.entity.EntityHumanNPC.damageEntity(EntityHumanNPC.java:185) [Citizens%20(5).jar:?] at net.minecraft.server.v1_12_R1.EntitySnowball.a(SourceFile:45) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12R1.EntityProjectile.B(EntityProjectile.java:167) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.World.entityJoinedWorld(World.java:1631) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.World.h(World.java:1601) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.World.tickEntities(World.java:1435) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.WorldServer.tickEntities(WorldServer.java:668) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.MinecraftServer.D(MinecraftServer.java:817) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:406) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:679) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:577) [Spigot.jar:git-Spigot-e8ded36-acbc348] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_211] Caused by: java.lang.NullPointerException at org.mcmonkey.sentinel.SentinelTrait.whenAttacksHappened(SentinelTrait.java:618) ~[?:?] at org.mcmonkey.sentinel.SentinelEventHandler.whenAttacksHappened(SentinelEventHandler.java:117) ~[?:?] at sun.reflect.GeneratedMethodAccessor76.invoke(Unknown Source) ~[?:?] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_211] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_211] at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:302) ~[Spigot.jar:git-Spigot-e8ded36-acbc348] ... 24 more
What's happening in the game server when this error appears? As far as I can tell from the trace... a snowball is hitting an NPC. From local testing, a snowball thrown by a player hitting an NPC just does nothing. A snowball thrown by an NPC at another NPC will slowly kill it, but without any errors.
npc have guns CrackShot
Opened Spigot 1.12.2, CrackShot 0.98.9, I gave an NPC a carbine, had it shoot an NPC to death, no error. Shot an NPC to death with a carbine in my hand, no error.
What is that timings supposed to tell me? I need a way to replicate your issue.
... I notice you're running a very old CrackShot alternative named "SwornGuns" - is that maybe related?
swornguns I use for players, and crackshot for npc
[17:13:06] [Server thread/INFO]: [Citizens] Exception while updating 65: null.
[17:13:06] [Server thread/WARN]: at org.mcmonkey.sentinel.SentinelItemHelper.shouldTakeDura(SentinelItemHelper.java:351) [17:13:06] [Server thread/WARN]: at org.mcmonkey.sentinel.SentinelAttackHelper.tryAttackInternal(SentinelAttackHelper.java:381) [17:13:06] [Server thread/WARN]: at org.mcmonkey.sentinel.SentinelAttackHelper.tryAttack(SentinelAttackHelper.java:66) [17:13:06] [Server thread/WARN]: at org.mcmonkey.sentinel.SentinelTrait.runUpdate(SentinelTrait.java:1076) [17:13:06] [Server thread/WARN]: at org.mcmonkey.sentinel.SentinelTrait.run(SentinelTrait.java:1285) [17:13:06] [Server thread/WARN]: at net.citizensnpcs.api.npc.AbstractNPC.update(AbstractNPC.java:428) [17:13:06] [Server thread/WARN]: at net.citizensnpcs.npc.CitizensNPC.update(CitizensNPC.java:283) [17:13:06] [Server thread/WARN]: at net.citizensnpcs.nms.v1_12R1.entity.EntityHumanNPC.B(EntityHumanNPC.java:167) [17:13:06] [Server thread/WARN]: at net.minecraft.server.v1_12_R1.World.entityJoinedWorld(World.java:1631) [17:13:06] [Server thread/WARN]: at net.citizensnpcs.nms.v1_12_R1.util.NMSImpl.tick(NMSImpl.java:1015) [17:13:06] [Server thread/WARN]: at net.citizensnpcs.util.NMS.tick(NMS.java:318) [17:13:06] [Server thread/WARN]: at net.citizensnpcs.util.PlayerUpdateTask.run(PlayerUpdateTask.java:36) [17:13:06] [Server thread/WARN]: at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftTask.run(CraftTask.java:76) [17:13:06] [Server thread/WARN]: at org.bukkit.craftbukkit.v1_12_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:361) [17:13:06] [Server thread/WARN]: at net.minecraft.server.v1_12_R1.MinecraftServer.D(MinecraftServer.java:739) [17:13:06] [Server thread/WARN]: at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:406) [17:13:06] [Server thread/WARN]: at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:679) [17:13:06] [Server thread/WARN]: at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:577) [17:13:06] [Server thread/WARN]: at java.lang.Thread.run(Thread.java:748)
I can't fix bugs I can't replicate. Please provide sufficient information to replicate the issue(s) you're encountering.
Actually that new error I can see how it came about and have fixed it. That fix is in build 261+
The original error, I still need a way to replicate it.
[20:14:53] [Server thread/INFO]: [m[0;33;22m__[m[m[0;33;22m.[ [m[0;32;22mMassiveLag Spike Monitor[m[0;33;22m ].[m[0;33;22m_____[m
[20:14:53] [Server thread/INFO]: [0;36;1mTick Length: [0;35;1m12844 [0;33;1mmilliseconds[m
[20:14:53] [Server thread/INFO]: [0;36;1mTPS Reduction: [0;35;1m255.9[0;33;1m ([0;35;1m20.0[0;33;1m --> [0;35;1m-235.9[0;33;1m)[m
[20:14:53] [Server thread/INFO]: [0;36;1mStack Tree: [0;37;22m(1285 samples)[m
[20:14:53] [Server thread/INFO]: [0;37;1m97.67% [0;33;1mnet.citizensnpcs.util.PlayerUpdateTask[0;37;22m.[0;32;1mrun[0;37;22m([0;36;1mPlayerUpdateTask.java[0;37;22m:[0;35;1m36[0;37;22m)[m
[20:14:53] [Server thread/INFO]: [0;30;1m97.67% [0;33;1mnet.citizensnpcs.util.NMS[0;37;22m.[0;32;1mtick[0;37;22m([0;36;1mNMS.java[0;37;22m:[0;35;1m318[0;37;22m)[m
[20:14:53] [Server thread/INFO]: [0;30;1m97.67% [0;33;1mnet.citizensnpcs.nms.v1_12_R1.util.NMSImpl[0;37;22m.[0;32;1mtick[0;37;22m([0;36;1mNMSImpl.java[0;37;22m:[0;35;1m1015[0;37;22m)[m
[20:14:53] [Server thread/INFO]: [0;30;1m97.59% [0;33;1mnet.minecraft.server.v1_12_R1.World[0;37;22m.[0;32;1mentityJoinedWorld[0;37;22m([0;36;1mWorld.java[0;37;22m:[0;35;1m1631[0;37;22m)[m
[20:14:53] [Server thread/INFO]: [0;30;1m97.59% [0;33;1mnet.citizensnpcs.nms.v1_12R1.entity.EntityHumanNPC[0;37;22m.[0;32;1mB[0;37;22m([0;36;1mEntityHumanNPC.java[0;37;22m:[0;35;1m167[0;37;22m)[m
[20:14:53] [Server thread/INFO]: [0;30;1m97.59% [0;33;1mnet.citizensnpcs.npc.CitizensNPC[0;37;22m.[0;32;1mupdate[0;37;22m([0;36;1mCitizensNPC.java[0;37;22m:[0;35;1m289[0;37;22m)[m
[20:14:53] [Server thread/INFO]: [0;30;1m97.59% [0;33;1mnet.citizensnpcs.npc.ai.CitizensNavigator[0;37;22m.[0;32;1mrun[0;37;22m([0;36;1mCitizensNavigator.java[0;37;22m:[0;35;1m160[0;37;22m)[m
[20:14:53] [Server thread/INFO]: [0;30;1m97.59% [0;33;1mnet.citizensnpcs.npc.ai.MCNavigationStrategy[0;37;22m.[0;32;1mupdate[0;37;22m([0;36;1mMCNavigationStrategy.java[0;37;22m:[0;35;1m77[0;37;22m)[m
[20:14:53] [Server thread/INFO]: [0;30;1m97.59% [0;33;1mnet.citizensnpcs.nms.v1_12_R1.util.NMSImpl$5[0;37;22m.[0;32;1mupdate[0;37;22m([0;36;1mNMSImpl.java[0;37;22m:[0;35;1m502[0;37;22m)[m
[20:14:53] [Server thread/INFO]: [0;30;1m97.59% [0;33;1mnet.citizensnpcs.nms.v1_12_R1.util.NMSImpl$4[0;37;22m.[0;32;1mapply[0;37;22m([0;36;1mNMSImpl.java[0;37;22m:[0;35;1m445[0;37;22m)[m
[20:14:53] [Server thread/INFO]: [0;30;1m97.59% [0;33;1mnet.citizensnpcs.nms.v1_12_R1.util.NMSImpl$4[0;37;22m.[0;32;1mapply[0;37;22m([0;36;1mNMSImpl.java[0;37;22m:[0;35;1m448[0;37;22m)[m
[20:14:53] [Server thread/INFO]: [0;30;1m97.59% [0;33;1mnet.citizensnpcs.nms.v1_12_R1.util.PlayerNavigation[0;37;22m.[0;32;1ma[0;37;22m([0;36;1mPlayerNavigation.java[0;37;22m:[0;35;1m78[0;37;22m)[m
[20:14:53] [Server thread/INFO]: [0;30;1m97.59% [0;33;1mnet.minecraft.server.v1_12_R1.NavigationAbstract[0;37;22m.[0;32;1ma[0;37;22m([0;36;1mSourceFile[0;37;22m:[0;35;1m93[0;37;22m)[m
[20:14:53] [Server thread/INFO]: [0;30;1m97.59% [0;33;1mnet.citizensnpcs.nms.v1_12_R1.util.PlayerNavigation[0;37;22m.[0;32;1mb[0;37;22m([0;36;1mPlayerNavigation.java[0;37;22m:[0;35;1m268[0;37;22m)[m
[20:14:53] [Server thread/INFO]: [0;30;1m97.59% [0;33;1mnet.citizensnpcs.nms.v1_12_R1.util.PlayerNavigation[0;37;22m.[0;32;1mb2[0;37;22m([0;36;1mPlayerNavigation.java[0;37;22m:[0;35;1m308[0;37;22m)[m
[20:14:53] [Server thread/INFO]: [0;30;1m97.59% [0;33;1mnet.minecraft.server.v1_12_R1.ChunkCache[0;37;22m.[0;32;1m
That's unreadable nonsense. Closing until you're able to answer my request.
server hangs at intervals
That error is not even remotely related to the initial error.
That also is literally is just a stack trace of the world loading. If that's eating time it's because the world generator isn't super fast.
how to fix?
Locking this issue as you seem disinterested in providing replication info for the original error, and instead are just posting unrelated nonsense.
[08:43:36 ERROR]: Could not pass event EntityDamageByEntityEvent to Sentinel v1.9.1 (build 253) org.bukkit.event.EventException: null at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[Spigot.jar:git-Spigot-e8ded36-acbc348] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[Spigot.jar:git-Spigot-e8ded36-acbc348] at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:500) [Spigot.jar:git-Spigot-e8ded36-acbc348] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:485) [Spigot.jar:git-Spigot-e8ded36-acbc348] at org.bukkit.craftbukkit.v1_12_R1.event.CraftEventFactory.callEvent(CraftEventFactory.java:93) [Spigot.jar:git-Spigot-e8ded36-acbc348] at org.bukkit.craftbukkit.v1_12_R1.event.CraftEventFactory.callEntityDamageEvent(CraftEventFactory.java:580) [Spigot.jar:git-Spigot-e8ded36-acbc348] at org.bukkit.craftbukkit.v1_12_R1.event.CraftEventFactory.handleEntityDamageEvent(CraftEventFactory.java:483) [Spigot.jar:git-Spigot-e8ded36-acbc348] at org.bukkit.craftbukkit.v1_12_R1.event.CraftEventFactory.handleLivingEntityDamageEvent(CraftEventFactory.java:612) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.EntityLiving.damageEntity0(EntityLiving.java:1346) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.EntityHuman.damageEntity0(EntityHuman.java:846) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.EntityLiving.damageEntity(EntityLiving.java:868) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.EntityHuman.damageEntity(EntityHuman.java:759) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.EntityPlayer.damageEntity(EntityPlayer.java:586) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.citizensnpcs.nms.v1_12_R1.entity.EntityHumanNPC.damageEntity(EntityHumanNPC.java:185) [Citizens%20(5).jar:?] at net.minecraft.server.v1_12_R1.EntitySnowball.a(SourceFile:45) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12R1.EntityProjectile.B(EntityProjectile.java:167) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.World.entityJoinedWorld(World.java:1631) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.World.h(World.java:1601) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.World.tickEntities(World.java:1435) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.WorldServer.tickEntities(WorldServer.java:668) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.MinecraftServer.D(MinecraftServer.java:817) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.DedicatedServer.D(DedicatedServer.java:406) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.MinecraftServer.C(MinecraftServer.java:679) [Spigot.jar:git-Spigot-e8ded36-acbc348] at net.minecraft.server.v1_12_R1.MinecraftServer.run(MinecraftServer.java:577) [Spigot.jar:git-Spigot-e8ded36-acbc348] at java.lang.Thread.run(Thread.java:748) [?:1.8.0_211] Caused by: java.lang.NullPointerException at org.mcmonkey.sentinel.SentinelTrait.whenAttacksHappened(SentinelTrait.java:618) ~[?:?] at org.mcmonkey.sentinel.SentinelEventHandler.whenAttacksHappened(SentinelEventHandler.java:117) ~[?:?] at sun.reflect.GeneratedMethodAccessor68.invoke(Unknown Source) ~[?:?] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_211] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_211] at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:302) ~[Spigot.jar:git-Spigot-e8ded36-acbc348] ... 24 more
why?