mcmonkeyprojects / Sentinel

Combat NPCs for Spigot!
MIT License
168 stars 84 forks source link

Sentinels with Crackshot Weapons Firing 1 Block Too Low #304

Closed kagaminecyn closed 5 years ago

kagaminecyn commented 5 years ago

MC: Spigot 1.14.3 Citizens: 2.0.25-SNAPSHOT (build 1719) Sentinel: 1.9.2 (build 261)

Issue: Sentinels shooting guns have difficulty shooting spiders. Gun-shooting sentinels appear to shoot 1 block lower than the entity's height, so since a spider is 1 block tall, the Sentinel keeps trying to shoot into the ground under the spider, so it can't hit the spider. Make targeting 1 block higher for Crackshot-shooting Sentinels please?

mcmonkey4eva commented 5 years ago

That's... odd. The internal code specifically aims directly towards the target's eye location (ie ent.getEyeLocation()). It might just be a really weird eye location for spiders?

mcmonkey4eva commented 5 years ago

Tested locally, Sentinel with a CrackShot gun ('carbine') is able to perfectly hit spiders. Aim does not appear to be wrong for any mob types.

mcmonkey4eva commented 5 years ago

Need sufficient information to recreate the issue before I can do anything about it.