mcmonkeyprojects / sd-dynamic-thresholding

Dynamic Thresholding (CFG Scale Fix) for Stable Diffusion (eSwarmUI, ComfyUI, and Auto WebUI)
MIT License
1.11k stars 103 forks source link

Dropdown #46

Open SepticSpoons opened 1 year ago

SepticSpoons commented 1 year ago

Can you please consider changing the interface to have the whole thing nested in a dropdown instead of how it currently is?

example: (I have no idea how to actually implement this, I just used inspect to show what I mean)

Screenshot 2023-06-21 141810

This is how it currently is. (You can make it smaller by closing the adv options dropdown)

How I think it should look:

Screenshot 2023-06-21 1418101

The second one looks much cleaner imo and follows the same format as all the other extensions.

Thanks.

p.s I'm sorry, I don't know how to assign a label

mcmonkey4eva commented 1 year ago

It's designed to fit with the base UI, rather than the awkward way some other extensions were forced to work. Every optional feature in the base webui is controlled via checkbox.

Some extensions are very bad here, eg ControlNet you have to open a dropdown and hit a checkbox - because DynThresh makes significant changes without any parameter-touching, it would have to work the same (both dropdown and checkbox), which is really awkward, and leads much too often to accidentally configuring an extension without enabling it.

Imo it'd be much better to work the other direction here - encourage other extensions to switch to the clear format that both the base auto webui, and dynthresh, use - a checkbox-based enabler.

--

ps I posted in the webui dev discord for feedback

image

wkpark commented 1 year ago

I don't think custom gradio named uiwhatever will be made or used in the meantime to webui. but I also agree with you that the current ui of the extensions is not good for endusers.