Comfyui Error after update 2998d4c

[xueqing0622]

Comfyui Error after update 2998d4c

Error occurred when executing KSampler:

'input'

File "F:\ComfyUI\ComfyUI\execution.py", line 153, in recursive_execute output_data, output_ui = get_output_data(obj, input_data_all) File "F:\ComfyUI\ComfyUI\execution.py", line 83, in get_output_data return_values = map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True) File "F:\ComfyUI\ComfyUI\execution.py", line 76, in map_node_over_list results.append(getattr(obj, func)(slice_dict(input_data_all, i))) File "F:\ComfyUI\ComfyUI\nodes.py", line 1237, in sample return common_ksampler(model, seed, steps, cfg, sampler_name, scheduler, positive, negative, latent_image, denoise=denoise) File "F:\ComfyUI\ComfyUI\nodes.py", line 1207, in common_ksampler samples = comfy.sample.sample(model, noise, steps, cfg, sampler_name, scheduler, positive, negative, latent_image, File "F:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Impact-Pack\modules\impact\sample_error_enhancer.py", line 9, in informative_sample return original_sample(args, kwargs) File "F:\ComfyUI\ComfyUI\comfy\sample.py", line 100, in sample samples = sampler.sample(noise, positive_copy, negative_copy, cfg=cfg, latent_image=latent_image, start_step=start_step, last_step=last_step, force_full_denoise=force_full_denoise, denoise_mask=noise_mask, sigmas=sigmas, callback=callback, disable_pbar=disable_pbar, seed=seed) File "F:\ComfyUI\ComfyUI\comfy\samplers.py", line 728, in sample return sample(self.model, noise, positive, negative, cfg, self.device, sampler(), sigmas, self.model_options, latent_image=latent_image, denoise_mask=denoise_mask, callback=callback, disable_pbar=disable_pbar, seed=seed) File "F:\ComfyUI\ComfyUI\comfy\samplers.py", line 633, in sample samples = sampler.sample(model_wrap, sigmas, extra_args, callback, noise, latent_image, denoise_mask, disable_pbar) File "F:\ComfyUI\ComfyUI\comfy\samplers.py", line 589, in sample samples = getattr(k_diffusionsampling, "sample{}".format(sampler_name))(model_k, noise, sigmas, extra_args=extra_args, callback=k_callback, disable=disable_pbar, extra_options) File "F:\ComfyUI\python_embeded\lib\site-packages\torch\utils_contextlib.py", line 115, in decorate_context return func(args, kwargs) File "F:\ComfyUI\ComfyUI\comfy\k_diffusion\sampling.py", line 137, in sample_euler denoised = model(x, sigma_hat * s_in, extra_args) File "F:\ComfyUI\python_embeded\lib\site-packages\torch\nn\modules\module.py", line 1501, in _call_impl return forward_call(*args, *kwargs) File "F:\ComfyUI\ComfyUI\comfy\samplers.py", line 287, in forward out = self.inner_model(x, sigma, cond=cond, uncond=uncond, cond_scale=cond_scale, model_options=model_options, seed=seed) File "F:\ComfyUI\python_embeded\lib\site-packages\torch\nn\modules\module.py", line 1501, in _call_impl return forward_call(args, kwargs) File "F:\ComfyUI\ComfyUI\comfy\k_diffusion\external.py", line 129, in forward eps = self.get_eps(input * c_in, self.sigma_to_t(sigma), *kwargs) File "F:\ComfyUI\ComfyUI\comfy\k_diffusion\external.py", line 155, in get_eps return self.inner_model.apply_model(args, **kwargs) File "F:\ComfyUI\ComfyUI\comfy\samplers.py", line 275, in apply_model out = sampling_function(self.inner_model.apply_model, x, timestep, uncond, cond, cond_scale, model_options=model_options, seed=seed) File "F:\ComfyUI\ComfyUI\comfy\samplers.py", line 256, in sampling_function return model_options"sampler_cfg_function" File "F:\ComfyUI\ComfyUI\custom_nodes\sd-dynamic-thresholding\dynthres_comfyui.py", line 33, in sampler_dyn_thresh input = args["input"]

[mcmonkey4eva]

Have you updated Comfy?

[xueqing0622]

after update comfyui, fixed now, but the effect is not as good as before, I find comfyui update the sampler file too. maybe need some fixed updates,

[mcmonkey4eva]

The update was because comfy updated sampler core, and the sampler code updated because of dyn thresh - more precisely because of #81 - DynThresh in comfy wasn't actually working properly at all until now.

[xueqing0622]

ok, thx, after tweak some parameters, it get better now