search

mcmonkeyprojects / sd-dynamic-thresholding

Dynamic Thresholding (CFG Scale Fix) for Stable Diffusion (eSwarmUI, ComfyUI, and Auto WebUI)
MIT License
1.1k stars 103 forks source link

Scheduled Value (in ComfyUI node) seems to do nothing? #84

Closed EricRollei closed 9 months ago

EricRollei commented 9 months ago

Thanks for making this node for Comfy. Maybe more of a question than a bug... It's super hard to find detailed info on what some of the features do so I've been doing XY testing. In that testing, it appears that the sched_val setting does not change anything. Is it there just for organizational purposes ie to keep track of what the user intends to set CFG in the sampler? or was it there to do something? Or did it come from the A1111 port?

mcmonkey4eva commented 9 months ago

[DT] Scheduler Value if that's what you're referring to, is part of Dynamic Thresholding, which is documented in detail @ https://github.com/mcmonkeyprojects/sd-dynamic-thresholding/wiki (Edit: yes this lol, the wiki has docs)

If you view the parameter in the normal param list (under Advanced in this case), there's a ? you can click for in-UI documentation image

If you meant the Scheduler Type, that's a sub-parameter of Sampler. Auto WebUI combines Sampler+Scheduler into one (eg "DPM++ 2M Karras" is the sampler "DPM++ 2M" with the scheduler "Karras"). Sampler specifics are fairly minor and don't need to be fiddle with much.

EDIT: I've been answering swarm questions all day and didn't notice I was back on the raw dynthresh repo for this one, sorry, lol. ... Use Swarm tho it documents this more clearly as shown above lol

EricRollei commented 9 months ago

Hey, I read the wiki first, didn't find any info on that setting but thank you for the quick reply - edit ah I see the answer is in the image pasted. I don't know much about stable swarm, will check it out. I'm asking about the option in the full version node for ComfyUI. See the field "sched_val". It does nothing mostly. But is it perhaps only use when you have Power Up selected? Power-up needs a variable? Edit - okay- that was a right guess. Never noticed the repeating options will have to play with those.

image

mcmonkey4eva commented 9 months ago

sched_val is Scheduler Value, as explained in the screenshot above and also at https://github.com/mcmonkeyprojects/sd-dynamic-thresholding/wiki/Schedulers