search

mcmtroffaes / inipp

Simple C++ ini parser.
MIT License
282 stars 53 forks source link

bump cmake version to 2.8.12 #18

Closed MixusMinimax closed 3 years ago

MixusMinimax commented 3 years ago

Solves this warning (and potential issue in the future)

Compatibility with CMake < 2.8.12 will be removed from a future version of CMake.
mcmtroffaes commented 3 years ago

Could you please explain what bug this patch is fixing, and how to reproduce it?

MixusMinimax commented 3 years ago

Versions below 2.8.12 are deprecated, and when configuring the cmake project, cmake spits out a warning. Right now it's just a warning, but they won't support those old versions in the future. My cmake version: 3.20.2 Full output when building the current project (mkdir build && cd build && cmake ..):

CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 2.8.12 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.
mcmtroffaes commented 3 years ago

Ok, let's act on this now.

mcmtroffaes commented 3 years ago

Thanks for the contribution!