search

mcmtroffaes / pycddlib

A Python wrapper for Komei Fukuda's cddlib.
http://packages.python.org/pycddlib/
GNU General Public License v2.0
61 stars 9 forks source link

Expose adjacency and incidence. #36

Closed mcmtroffaes closed 5 years ago

mcmtroffaes commented 5 years ago

Built on top of #34.

mcmtroffaes commented 5 years ago

@bobmyhill I'd prefer to keep pycddlib as close as possible to the original cddlib. Therefore, I'd prefer just to expose the adjacency/incidence functions directly, rather than your more fancy vertex/facet functions that pick the function to call depending on the representation. The thing builds but I still need to update the tests.

Thoughts?

bobmyhill commented 5 years ago

@mcmtroffaes I have no issue with this, especially if it makes life easier for those migrating to pycddlib from cddlib. The only thing I would like in this case is some basic notes on the relationship between vertex/facet, adjacency/incidence and H/V representation in the documentation. I'm happy to add these if you want.

I like the changes you've made to the code - it's much more compact now.

mcmtroffaes commented 5 years ago

@bobmyhill Thanks again for your work on this!