mcnamee / react-native-starter-kit

:rocket: A React Native boilerplate app to get you up and running very, very quickly :rocket:
MIT License
3.35k stars 865 forks source link

Fix firebase warnings. #218

Closed Undeadlol1 closed 4 years ago

Undeadlol1 commented 5 years ago

In Android on Windows there a constant Firebase warning which usually results in "v8 is out of memory" error. Image 274

Image 275

This workaround doesn't solve the issue completely but it removes the warnings and crashes occur much-much less frequently.

Image 276

See the firebase issue for more info: https://github.com/firebase/firebase-js-sdk/issues/97

elolelo commented 5 years ago

Have you tried to use line: console.disableYellowBox = true; Although it does not solve the issue completely, it does remove the warnings (at least it did to mine)

Undeadlol1 commented 5 years ago

Disabling all warnings is not a great decision. It might come back and bite you in the future.

elolelo commented 5 years ago

"Disabling all warnings is not a great decision. It might come back and bite you in the future."

They might come back ... how about this link https://stackoverflow.com/a/46678121 ?

Undeadlol1 commented 5 years ago

They might come back ... how about this link https://stackoverflow.com/a/46678121 ?

This is pretty much what my PR does.

elolelo commented 5 years ago

They might come back ... how about this link https://stackoverflow.com/a/46678121 ?

This is pretty much what my PR does.

Are you saying your PR did this? did it work? I am facing these yellow issues too . This stackoverflow didn't work for me - did it work for you or your PR?

Undeadlol1 commented 5 years ago

Yes, PR removes the yellow box.

mcnamee commented 5 years ago

Hi @Undeadlol1 I understand why you've done this. Can you separate the specifics into a separate module/file (perhaps call it something like /src/lib/firebase-fix.js or something similar) so that it's separated and easily removed (if/when Firebase is fixed)?