Closed jagadhis closed 2 months ago
@jagadhis is attempting to deploy a commit to the MC Naveen's projects Team on Vercel.
A member of the Team first needs to authorize it.
Hi @jagadhis Thanks for the PR.
Can you check the action logs for on-pull-request
. I see a bunch of errors.
Example:
1:1 Error: Definition for rule '@stylistic/indent' was not found. @stylistic/indent
1:1 Error: Definition for rule '@stylistic/quotes' was not found. @stylistic/quotes
1:1 Error: Definition for rule '@stylistic/object-curly-spacing' was not found. @stylistic/object-curly-spacing
1:1 Error: Definition for rule '@stylistic/jsx-tag-spacing' was not found. @stylistic/jsx-tag-spacing
@mcnaveen can you authorize and try it now ?
@mcnaveen i saw the errors it is typescript i will try to resolve it
Okay. I know what is causing these errors now. Maybe #13 will fix these.
@mcnaveen yeah i should have tackled that first i will fix this first and will try to take on #13 since it is big change
Yeah. It's bigger. I planned to work on this today. Once done. I'll have more core features lined up.
@mcnaveen this will work i checked in local there was no eslint errors for now i have disabled the rules once we fix issue #13 we can enable it again
Awesome, Thanks for your awesome work. I'm going to merge this now. Do you have a hacktoberfest profile setup already? https://hacktoberfest.com/
@mcnaveen nope doing it now
@mcnaveen i have setup my profile on hacktoberfest thanks for letting me know beofre merging
Awesome. Thank you so much for your contribution. 🫡 You'll be added to contributor-only discord channel.
@all-contributors please add @jagadhis for code, ideas
@mcnaveen
I've put up a pull request to add @jagadhis! :tada:
Hi @mcnaveen would like you to review this pr
Changes done:
as i have removed some of the dependencies the reason for that is stylistic plugin will by default handle some of the rules if there is any rule we need to add we can further add to the eslintrc file
Resolves #14