search

mcndt / noteshare.space

A service for sharing encrypted Markdown notes from Obsidian. Notes are end-to-end-encrypted and are only stored temporarily.
https://noteshare.space
MIT License
208 stars 22 forks source link

Rendering Footnotes #24

Closed stoweboyd closed 2 years ago

stoweboyd commented 2 years ago

It would be good if footnotes were rendered in the copied file.

In my use case, I write comments and place tags and other annotations in footnotes, but for sharing with others those would be better at the foot of the rendered file.

mcndt commented 2 years ago

I agree, footnotes should be rendered correctly. I'll mark it as a future feature. Stay tuned!

mcndt commented 2 years ago

for future reference, a good starting point: https://github.com/markedjs/marked/issues/1562#issuecomment-551269829

mcndt commented 2 years ago

Works now!

stoweboyd commented 2 years ago

Doesn't seem to work in all cases: see https://noteshare.space/note/cl76nu7jj339101nuogo2pdp5#7BwC5OXgRneeFoalJM3GH6r-4iGTvVD7mVjW6w1HjtQ

Screen Shot 2022-08-23 at 4 49 55 PM

mcndt commented 2 years ago

So sorry for my late response, I have been traveling.

I am unfamiliar with this footnote syntax. Is it a way to define the footnote text inline? I was previously only familiar with this syntax:

This is a paragraph^[1].

[1]: This is the footnote text, which will be rendered at the bottom of the page.
stoweboyd commented 2 years ago

Yes, it is an inline footnote. Like^[this is a footnote] which shows at the foot of the rendered file with an ordinal and the text. See https://help.obsidian.md/How+to/Format+your+notes

You can also use inline footnotes. ^[notice that the carat goes outside of the brackets on this one.]

On Fri, Sep 9, 2022 at 4:53 PM Maxime Cannoodt @.***> wrote:

So sorry for my late response, I have been traveling.

I am unfamiliar with this footnote syntax. Is it a way to define the footnote text inline? I was previously only familiar with this syntax:

This is a paragraph^[1].

[1]: This is the footnote text, which will be rendered at the bottom of the page.

— Reply to this email directly, view it on GitHub https://github.com/mcndt/noteshare.space/issues/24#issuecomment-1242461344, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXFR3XNZE4KQCMY5H4SLLDV5OPTFANCNFSM57IF3PZA . You are receiving this because you authored the thread.Message ID: @.***>

mcndt commented 2 years ago

I created a new issue to track this bug separately, see #31.

stoweboyd commented 2 years ago

Still doesn't seem to be working?

On Sun, Sep 11, 2022 at 5:28 AM Maxime Cannoodt @.***> wrote:

Closed #24 https://github.com/mcndt/noteshare.space/issues/24 as completed.

— Reply to this email directly, view it on GitHub https://github.com/mcndt/noteshare.space/issues/24#event-7362136509, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXFR3U6KNJ7UTXATC3KXR3V5WQ43ANCNFSM57IF3PZA . You are receiving this because you authored the thread.Message ID: @.***>

mcndt commented 2 years ago

As I said, I created a new issue to track the bug. I haven't fixed it just yet :) But don't worry, it's on my radar.

You can subscribe to the new thread to follow progress: #31

stoweboyd commented 2 years ago

Aha!

On Sun, Sep 11, 2022 at 2:57 PM Maxime Cannoodt @.***> wrote:

As I said, I created a new issue to track the bug. I haven't fixed it just yet :) But don't worry, it's on my radar.

You can subscribe to the new thread to follow progress: #31 https://github.com/mcndt/noteshare.space/issues/31

— Reply to this email directly, view it on GitHub https://github.com/mcndt/noteshare.space/issues/24#issuecomment-1243022435, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXFR3V53FSHNMEZK42LJVTV5YTRRANCNFSM57IF3PZA . You are receiving this because you authored the thread.Message ID: @.***>