search

mcneel / compute.rhino3d

REST geometry server based on RhinoCommon and headless Rhino
Other
296 stars 185 forks source link

Geometry Contextual Input should not assume GeometryBase #239

Closed fraguada closed 3 years ago

fraguada commented 3 years ago

src here: https://github.com/mcneel/compute.rhino3d/blob/master/src/compute.geometry/GrasshopperDefinition.cs#L323-L334 If points are used, compute throws an error that it cannot extract keys from the dictionary.

mcneel-build commented 3 years ago

Linked with COMPUTE-192

fraguada commented 3 years ago

Nevermind...didn't see there was a points specific contextual input 🥇

sbaer commented 3 years ago

@fraguada should this be closed? It looks like the "Get Geometry" component supports points. Based on your comments it sounds like this is not working

fraguada commented 3 years ago

Maybe I closed too soon. Indeed, the Get Geometry calls this: https://github.com/mcneel/compute.rhino3d/blob/master/src/compute.geometry/GrasshopperDefinition.cs#L328-L340 Which assumes GeometryBase and thus fails if points are passed to it from a compute client.