search

mcneel / rhino-developer-samples

Rhino and Grasshopper developer sample code
http://developer.rhino3d.com
Other
612 stars 330 forks source link

Update SampleEtoModelessForm.py #13

Closed deKlerk closed 6 years ago

deKlerk commented 6 years ago

Form wasn't showing when I ran the script in GhPython (Rhino6), therefore I introduced some changes to the code (lines 38, 54, 65 and 215-222).

. Line 38 makes the form visible in the taskbar; . Line 54/65 changes sc.doc in order to solve the following error that was showing up in (now) line 61: "Runtime error (MissingMemberException): 'CustomTable' object has no attribute 'GetObjectList' " . Introducing the 'else: ' clause in line 215 solved the problem of the form not showing; the remaining lines were the necessary tabulations.

Cheers, RdK

dalefugier commented 6 years ago

Hi @deKlerk, thanks for submitting a pull request. However, I am not going to merge your changes. The ShowInTaskbar change is personal preference and counter standard Windows style. The ActiveDoc change might work for GhPython, but he sample works (already) for Rhino.Python.

Thanks again. -- Dale

deKlerk commented 6 years ago

Hi @dalefugier, thanks for the reply. As a GhPython user, I felt the need to share a solution for those constraints.

All the best, -- Rui