mcneel / rhino.inside-revit

This is the open-source repository for Rhino.Inside®.Revit
https://www.rhino3d.com/inside/revit/
MIT License
258 stars 65 forks source link

Family.New should not try to determine template file #127

Open eirannejad opened 4 years ago

eirannejad commented 4 years ago

See https://github.com/mcneel/rhino.inside-revit/blob/f6e5ac89bfd80dc5b291abff63770f9ea1fad42a/src/RhinoInside.Revit/GH/Components/Family.cs#L512

The purpose of Family.New is to generate a new family. By packing smart finders into the component, it is becoming unnecessarily complex.

It should be left to the user to determine the appropriate family template they need, or separate this functionality into another component.

kike-garbo commented 4 years ago

The user can decide which template file to use, but in case the template is not specified, the component try to load a Generic Model template. I think is handy for a quick setup of the definition.