search

mcneel / rhino3dm

Libraries based on OpenNURBS with a RhinoCommon style
MIT License
582 stars 135 forks source link

rhino3dm.js Module type definition aka rhino3dm.d.ts is a really mess! #433

Closed KaivnD closed 1 year ago

KaivnD commented 2 years ago

As you can see in the title, so much error in type definition file rhino3dm.d.ts. Few yeas ago, I found this module, which really got my attention. I like it, but when I use it with typescript, oh no, so much to // @ts-ignore, it really drive me mad, so I decided try to make things right, only if you guys let me, I can make pr for this.

sbaer commented 2 years ago

Feel free to submit a PR. This would require updating the ts file generator. The code that creates the ts file is at https://github.com/mcneel/rhino3dm/blob/main/src/docgen/JavascriptClass.cs#L206

fraguada commented 2 years ago

related to #431

fraguada commented 1 year ago

Closing this as we're tracking the fixes to d.ts in #470 and #431