search

mcneel / rhino3dm

Libraries based on OpenNURBS with a RhinoCommon style
MIT License
599 stars 135 forks source link

Fix git version parsing using regex in bootstrap.py #445

Open fraguada opened 2 years ago

fraguada commented 2 years ago

@dan-rigdon-bel there was a bug in the workflow_ci script that didn't use the check for changes in build scripts to in any of the build steps, which means the changes you made with to bootstrap.py here seemed to pass checks just fine but didn't actually trigger any builds.

fraguada commented 2 years ago

fyi @dan-rigdon-bel I've reverted your changes, but left your changes commented in the bootstrap script: https://github.com/mcneel/rhino3dm/blob/main/script/bootstrap.py#L298-L309