mcneilco / acas

http://mcneilco.com/acas.html
GNU General Public License v3.0
12 stars 5 forks source link

Endpoints are editable under Experiment Editor when Experiment is in "In Process" status #1068

Closed hhan-schrodinger closed 1 year ago

hhan-schrodinger commented 1 year ago

Description

When the experiment status in the experiment editor was changed from "Approved" or "Rejected" to "Created"/"In Process"/"Complete", the fields in the endpoint table were editable when they should not be editable in the experiment editor.

This was being caused by logic that would enable or disable all fields in the page when the status was changed from a locked status ("Approved"/"Rejected") to an unlocked status ("Created"/"In Process"/"Complete").

To fix this, I added some lines to the function that handles when the status is changed that will always disable the endpoint table fields (I brought a copy of the function from BaseEntityController so that I wouldn't change anything universally).

How Has This Been Tested?

Tested it by toggling between the different statuses of an experiment.