search

mcneilco / acas

http://mcneilco.com/acas.html
GNU General Public License v3.0
12 stars 5 forks source link

Bug Fix: Adding New Lot Copies Lot Corp Name and Causes Error in Subsequent Search Query #1070

Closed dalejerikson closed 1 year ago

dalejerikson commented 1 year ago

Description

When adding a new lot, the compound ID that gets copied over includes the lot suffix which results in the 'Next Step' failing (see screenshot).

Screen Shot 2023-01-25 at 10 56 34 AM

If the lot suffix is dropped then the subsequents steps function as normal.

This fix includes code to drop the lot suffix and prevents it from being copied over whenever a "New Lot" button is utilized.

Screen Shot 2023-01-25 at 10 57 57 AM

The second step now is successful.

Screen Shot 2023-01-25 at 10 59 11 AM

NOTE: This previously worked on an environment where ACASLabelSequences is not utilized.

How Has This Been Tested?

Manually

dalejerikson commented 1 year ago

Note: Spacing was messed up in VSCode. Will fix shortly.

dalejerikson commented 1 year ago

I was also wondering if making this code change in 3 places was fine considering the size/simplicity or if I should DRY. Additionally, for the purposes of testing, this change worked well. However, I'm not 100% sure if the location of this change is appropriate or if there's a better place to do this text processing.