ACAS-650: Fix report/image file uploading

[brianbolt]

Description

• Removed the logic in GenericDataParser around multiple file uploads. The logic was wrong as it was counting report files and image files when preventing duplicate experiment files. It would then prevent the user from moving forward if they provided a report file or image file with their upload.
• The reason I just removed the multiple experiment file logic is because the file widget already reports that the second file that was dragged and dropped is invalid, so the behavior that the UI stops the user from clicking next until they remove the invalid file seemed unnecessary. As long as the user knows that one file is valid and the second file uploaded is not valid, then the UI should allow the user to continue.

Related Issue

ACAS-650

How Has This Been Tested?

• Validated report file and image file attachments work when uploading an experiment file
• Validated that uploading and experiment file works and that subsequent uploads reports "Max number of files exceeded" but the next button is still enabled if they have one file
  • Validated clearing the experiment uploads allows you to upload a new experiment file

[brianbolt]

I see what looks like a function being removed but cannot tell what the impact of this is. Does the function call need to be removed as well?

No. This method was actually overriding its superclass method which was implementing ALMOST all of the same logic except for the top part which was the buggy part. That is, the function is still getting called but its the super implementation.