ACAS-701: Return status code 404 for get metalot route - Githubissues

mcneilco / acas

http://mcneilco.com/acas.html

GNU General Public License v3.0

12 stars 5 forks source link

ACAS-701: Return status code 404 for get metalot route #1114

Closed brianbolt closed 1 year ago

brianbolt commented 1 year ago

Description

ACAS should return 404, not 500 when a lot does not exist. Currently it returns 500 and on certain nginx proxied servers, the 500 error is swallowed and the front end cannot check for the error as it's replaced with an html structure. Then end result is that the UI hangs when a lot does not exist instead of showing "Lot does not exist" on the page.

Related Issue

ACAS-702

How Has This Been Tested?

Ran manual test in the UI to verify that the correct message is displayed. Ran ACAS client tests and verified tests pass.

brianbolt commented 1 year ago

LGTM! I see we have a number of other usages where the status code is set to 500, should we create a separate case?

Yes, thanks that's probably a good idea. I'll do that later today.