search

mcneilco / acas

http://mcneilco.com/acas.html
GNU General Public License v3.0
12 stars 5 forks source link

ACAS-704: Use project_type to determine if project is restricted #1118

Closed iamanandkr closed 1 year ago

iamanandkr commented 1 year ago

Description

LiveDesign is deprecating the boolean Project.restricted attribute in favour of Project.project_type enum attribute to support feature of allowing projects to support the feature of marking projects as "hyper restricted" where the project will not have access to data from unrestricted projects.

I don't have complete context of how ACAS uses the restricted aspect of the project but @brianbolt mentioned that ACAS doesn't really need to differentiate between LiveDesign concept of restricted and hyper restricted.

Related Issue

ACAS-704 SS-39969 & SS-43269 are targeted for 2024.1.0 and so we would also need to publish these changes in 2024.1.x release once the branch is created.

How Has This Been Tested?

I have verified manually by applying the changes on https://hyper-restricted-project-v5.k8s.dev.bb.schrodinger.com/ and uploading an experiment.

iamanandkr commented 1 year ago

I am closing the pull request in favour of doing a long term solution in ACAS-712