mcneilco / acas

http://mcneilco.com/acas.html
GNU General Public License v3.0
12 stars 5 forks source link

ACAS-739: Open in LiveDesign fails for image uploads experiments #1162

Closed tanaymakharia closed 5 months ago

tanaymakharia commented 6 months ago

Description

Removed the prefix 'inlineFileValue_' from assays_to_add -> resultType

Related Issue

ACAS-739

How Has This Been Tested?

I tested this on new mapping and no error were logged. I updated the mapping view query to previous mapping and no error were logged when I added the data to LR

brianbolt commented 6 months ago

@tanay-makharia Now that https://github.com/mcneilco/acas/pull/1166 is merged, if you merge release/2024.1.x into this branch it should work.

bffrost commented 5 months ago

I've filed ACAS-779 after looking into the cause of failures here. The cause is faulty logic in GHA to choose a fallback branch, plus the CentOS + R upgrade we've done on release/2024.3.x.