mcneilco / acas

http://mcneilco.com/acas.html
GNU General Public License v3.0
11 stars 5 forks source link

ACAS-774: Support R-4.4.0 changes #1165

Closed brianbolt closed 5 months ago

brianbolt commented 5 months ago

Description

https://cran.r-project.org/bin/windows/base/old/4.2.0/NEWS.R-4.2.0.html

Calling && or || with either argument of length greater than one now gives a warning (which it is intended will become an error).

In 4.3.0 this became an error: https://cran.r-project.org/bin/windows/base/old/4.3.0/NEWS.R-4.3.0.html

Calling && or || with LHS or (if evaluated) RHS of length greater than one is now always an error, with a report of the form 'length = 4' in coercion to 'logical(1)'

So now we get:

https://github.com/mcneilco/acas/blob/9d261eefd5600d3d650bc707c1476b788e346a6e/modules/GenericDataParser/src/server/generic_data_parser.R#L2008

Error in is.na(protocol) || protocolOfExperiment$id != protocol$id : 
  'length = 15' in coercion to 'logical(1)'

Related Issue

ACAS-744

How Has This Been Tested?