search

mcobit / retrosmc

An easier way to get retropie onto osmc
Other
212 stars 32 forks source link

install-retrosmc.sh "add fix to config.txt for sound" bug #31

Open FraserChapman opened 7 years ago

FraserChapman commented 7 years ago

The condition at - https://github.com/mcobit/retrosmc/blob/master/install-retrosmc.sh#L62 is a bit too simple, in that many configurations have the line 'dtparam=audio=on' but have it commented out, i.e. '#dtparam=audio=on'

As it is the grep will match these commented out line and then insert 'dtparam=audio=on' - thus breaking settings for any sound cards, overlays, etc.

I would suggest simply adding the caret to the command so that only lines starting match. e.g.

grep -e "^dtparam=audio=on'" /boot/config.txt

mcobit commented 7 years ago

Thanks for the suggestion. And of course you are right. I will test and fix this tomorrow.