mcobit / retrosmc

An easier way to get retropie onto osmc
Other
212 stars 32 forks source link

New launcher version with proper executable for shortcuts #55

Open gabrielmagno opened 6 years ago

gabrielmagno commented 6 years ago

I tried adding a shortcut for the Retrosmc launcher in my skin (pellucid), but retropie was being started during the dialog for creating the shortcut, before it was properly created.

I investigated a little bit, then realized that the proper plugin type (extension point) for retrosmc launcher should be changed. I modified it from xbmc.python.pluginsource to xbmc.python.script, and now it is properly working.

I think this would apply for many other plugins, menus and shortcuts. This would probably close #37 and #54 .

hissingshark commented 6 years ago

Nice one. That fixed it for me on Vero4k/OSMC when using the Aeon Nox skin.

homelessbrian commented 6 years ago

I installed the newest version and i seem to be having this same issue. Am I just installing the wrong thing? Im new to this so sorry if im just mixed up somehow.

hissingshark commented 6 years ago

These changes haven't been accepted yet so the current version is still the same. If you want to test it you either need to edit addon.xml in the plugin folder you've already installed and change the line: <extension point="xbmc.python.pluginsource" library="addon.py"> as described in the first post by gabrielmagno Or just clone his repository instead.