search

mcohen01 / amazonica

A comprehensive Clojure client for the entire Amazon AWS api.
1.01k stars 201 forks source link

Option to use java-time instead of joda #411

Open conan opened 5 years ago

conan commented 5 years ago

Currently Amazonica converts java.util.Dates to org.joda.time.DateTimes. Now that we have the time API from Java 8, and good support for it in clojure, it would be great to have an option to work with the native classes, or at least to leave java.util.Dates as they are without conversion.

henryw374 commented 4 years ago

I think just leave dates alone and/or make the conversion extensible.

interested in a PR? if so, is a breaking change (ie no joda dep) ok?

henryw374 commented 4 years ago

PR here https://github.com/mcohen01/amazonica/pull/431

In the meantime, it's quite straightforward to add one extend-protocol of IMarshall and one alter-var-root of to-date in your own project.

ieugen commented 2 years ago

I also support moving to standard libraries and dropping extra code. Long term is easier for maintenance, including security related issues (post log4j bulnerabilities). Less is more.

henryw374 commented 2 years ago

yeah I actually stopped using Amazonica and use the official java v2 client directly - not difficult from Clojure & it's well documented

Limess commented 2 years ago

This'd be very nice to stop us from having to pull in clj-time in all our libraries. We'd prefer to not immediately have to switch to the java SDK or https://github.com/cognitect-labs/aws-api.