search

mcohen01 / node-quickbooks

nodejs client for Intuit's Quickbooks API
332 stars 235 forks source link

replace jxon with fast-xml-parser #219

Closed Nhasa closed 8 months ago

Nhasa commented 1 year ago

resolve #218

Hi @mcohen01 ,

Awesome work on the SDK firstly 👏 Not sure if you already have a solution implemented to tackle the issue https://github.com/mcohen01/node-quickbooks/issues/218 and have not published yet for the developer community.

It seems there's no response for this PR https://github.com/tyrasd/jxon/pull/55. So, I'm suggesting to replace jxon to fast-xml-parser instead.

Look forward to your feedback. Thanks for your time.

dteirney commented 8 months ago

@mcohen01 are you available to review the PR that is here to avoid a published CVE related to the use of jxon? We're looking at options to not have this CVE in our application libraries.

mcohen01 commented 8 months ago

2.0.44 is on npm