search

mcohen01 / node-quickbooks

nodejs client for Intuit's Quickbooks API
332 stars 235 forks source link

maxResults greater than limit #89

Closed darrinholst closed 6 years ago

darrinholst commented 7 years ago

I was trying to retrieve a bunch of time activities using fetchAll and the response from intuit was timing out at the default 1000 limit. I changed the limit to 100 which got the query working, but it stopped after the first request.

The response I got showed maxResults as 101...

    "startPosition": 1,
    "maxResults": 101

The api documentation does say that it's supposed to contain the number of records returned which is 100...

maxresults—The number of entity elements in the <QueryResponse> element.

Not sure if this is a change in the intuit api, but would you accept a PR that changed the === to >= here. Doing that locally gets it working again for me again.

darrinholst commented 7 years ago

I checked again and I am getting 101 records back instead of the 100 defined by the limit. I'm not sure what's going on. Seems like an intuit bug.