Add new index.html

[paulvickers]

The previous one turned out to have some unmatched tags. Sorry! Can we try this version please?

[mcolburn]

I pasted the index.html content into this online html validator:

https://validator.w3.org

I fixed all error it found, and pushed them to https://github.com/mcolburn/durham

So, you need to do a pull.

Even after fixing all errors found by the validator, the generator still hangs when I use the Durham Divine Liturgy html.

The editor works, though.

Here is what I think we need to do:

Presbytera can use OLW to enter the remaining Romanian. I will go ahead and get you set up to use Doxa. You can use it to generate the PDF file.

But, keep in mind that Doxa is still under development.

How does that sound to you?

On Jul 31, 2023, at 1:02 PM, Paul Vickers @.***> wrote:

The previous one turned out to have some unmatched tags. Sorry! Can we try this version please?

— Reply to this email directly, view it on GitHub https://github.com/mcolburn/durham/issues/77, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFXSOMDTF2H3PBKXOJQCLXTAFL7ANCNFSM6AAAAAA26XV4IU. You are receiving this because you are subscribed to this thread.

[paulvickers]

Hmmm. How much control will Doxa give me over layout (fonts, responses next to/below actors, cover pages, etc.)? Might it be worth reverting back to the index.html that did work?

You will also see from the email I sent that there is a problem with the Romanian text entry. The template seems to be putting en_UK_durlash keys into the Romanian version rather than ro_UK_dur.

[mcolburn]

Doxa will give you total control over the layout, the fonts, etc.

But, let me think about the issues you have been running into and whether there is a better temporary alternative for you to use for now, e.g. using a pure OSLW solution.

On Aug 1, 2023, at 2:50 AM, Paul Vickers @.***> wrote:

Hmmm. How much control will Doxa give me over layout (fonts, responses next to/below actors, cover pages, etc.)? Might it be worth reverting back to the index.html that did work?

You will also see from the email I sent that there is a problem with the Romanian text entry. The template seems to be putting en_UK_durlash keys into the Romanian version rather than ro_UK_dur.

— Reply to this email directly, view it on GitHub https://github.com/mcolburn/durham/issues/77#issuecomment-1659968086, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFXSNTEP76OYYSBODGJITXTDGO3ANCNFSM6AAAAAA26XV4IU. You are receiving this because you commented.

[mcolburn]

I pushed the latest index.html. The editor seems to be OK. Please verify. However, the generator still hangs. I will see if I can find an obvious reason.

[paulvickers]

Thanks, Michael. I pushed one more up 20 mins or so ago which had a minor change.

[mcolburn]

I pushed to OLW. I am trying to get a debugger going on my dev for OLW to see if I can spot an obvious reason for why the generator hangs. Intellij Idea's debugger has stopped working on my code and can't figure out why. I just now got Visual Studio Code to work debugging java. So, perhaps in a few hours I will know what the problem is.

[paulvickers]

I just spotted one empty (of text) key pair in the index.html which I have now removed (just below the heading of the Holy Anaphora):

<tr>
<td class='leftCell'><span class='kvp' data-key='properties_gr_GR_cog|media.key'><span class='media-group-empty'></span></span>
</td>
<td class='rightCell'><span class='kvp' data-key='properties_en_US_goa|media.key'><span class='media-group-empty'></span></span> </td>
</tr>

[mcolburn]

Empty is not a problem.

On Aug 1, 2023, at 11:01 AM, Paul Vickers @.***> wrote:

I just spotted one empty (of text) key pair in the index.html which I have now removed (just below the heading of the Holy Anaphora):

— Reply to this email directly, view it on GitHub https://github.com/mcolburn/durham/issues/77#issuecomment-1660828931, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFXSK4YNZJQH26OTMBINLXTE76XANCNFSM6AAAAAA26XV4IU. You are receiving this because you commented.

[paulvickers]

ok, just that in the editor it shows up as properties ~ media.key

[mcolburn]

Yes, that is a place holder so the user has something to click on to open the record editor. It displays like that if the value is empty.

If it is not needed for your use, it can be removed as you did.

On Aug 1, 2023, at 11:06 AM, Paul Vickers @.***> wrote:

ok, just that in the editor it shows up as properties ~ media.key

— Reply to this email directly, view it on GitHub https://github.com/mcolburn/durham/issues/77#issuecomment-1660835922, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFXSMUDBV736XNITJVGFTXTFAR3ANCNFSM6AAAAAA26XV4IU. You are receiving this because you commented.

[paulvickers]

Ah, I see.

Is it worth me replacing all the uk_durlash domain tags with us_goa do you think?

[mcolburn]

Hold off for now.

I finally have breakpoints set in the correct place in the OLW code and I will be able to determine where and hopefully why the generation is hanging, without reporting an error back.

On Aug 1, 2023, at 11:16 AM, Paul Vickers @.***> wrote:

Ah, I see.

Is it worth me replacing all the uk_durlash domain tags with us_goa do you think?

— Reply to this email directly, view it on GitHub https://github.com/mcolburn/durham/issues/77#issuecomment-1660849444, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFXSIWCEYRVMQM5LZXJUDXTFBWVANCNFSM6AAAAAA26XV4IU. You are receiving this because you commented.

[mcolburn]

Making progress.

I now know the exact line in the code where an array out of bounds error is thrown. Don't know the cause yet, or why OLW doesn't report the error to the user....

On Aug 1, 2023, at 11:16 AM, Paul Vickers @.***> wrote:

Ah, I see.

Is it worth me replacing all the uk_durlash domain tags with us_goa do you think?

— Reply to this email directly, view it on GitHub https://github.com/mcolburn/durham/issues/77#issuecomment-1660849444, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFXSIWCEYRVMQM5LZXJUDXTFBWVANCNFSM6AAAAAA26XV4IU. You are receiving this because you commented.

[paulvickers]

Weird that it should suddenly begin doing that. It couldn't be anything to do with large comment blocks, could it?

[paulvickers]

Might it be worth putting back in the last version of index.html that didn't throw an error? If it works, I could then clean that one up to remove the mismatched tags & domains.

[mcolburn]

Paul, please test on OLW. I found the source of the array out of bounds error in my code. It was an execution path caused when a data-key did not parse properly.

The durham liturgy works now for both the editor and generator.

I need to work with the data from the index.html file to figure out why some of the data-key values are not being parsed properly. Even though the output seems correct and OLW is happy, I am not until I get to the bottom of the instances where the data-key did not parse correctly.

On Aug 1, 2023, at 2:34 PM, Paul Vickers @.***> wrote:

Might it be worth putting back in the last version of index.html that didn't throw an error? If it works, I could then clean that one up to remove the mismatched tags & domains.

— Reply to this email directly, view it on GitHub https://github.com/mcolburn/durham/issues/77#issuecomment-1661131924, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFXSNOJIWH7RAU3PLRKQTXTFZAFANCNFSM6AAAAAA26XV4IU. You are receiving this because you commented.

[paulvickers]

Bless you, Michael. I hope this parsing issue helps with Doxa too... I still need to make a couple more tweaks to the template (there are some ChoirL and ChoirR instances that I just want to be Choir) so will upload a new version of index.html later. I hope this won't cause any further issues for you.

[mcolburn]

Hi, Paul!

No worries!

Glad it is working correctly now.

Even though the array out of bounds error was caught in the OLW server code and passed in the http response back to the OLW front-end app (running on the browser), in this case, I did not check the status code. I only checked to see if I had received data. So, the response was received, but not handled properly if there was no data in the response. That left the spinner (wait) icon in place indefinitely. Yesterday, I fixed it so the code checks for a 200 (ok) response code and displays a message to the user if there is a problem and removes the spinner icon.

In Doxa, I always check the response status code.

-Michael

On Aug 1, 2023, at 11:37 PM, Paul Vickers @.***> wrote:

Bless you, Michael. I hope this parsing issue helps with Doxa too... I still need to make a couple more tweaks to the template (there are some ChoirL and ChoirR instances that I just want to be Choir) so will upload a new version of index.html later. I hope this won't cause any further issues for you.

— Reply to this email directly, view it on GitHub https://github.com/mcolburn/durham/issues/77#issuecomment-1661584435, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFXSLANME55YACYKTNEILXTHYRPANCNFSM6AAAAAA26XV4IU. You are receiving this because you commented.

[paulvickers]

Thanks again. I've pushed what I hope is the final index.html to the repo. I decided to replace all Choir IDs with People IDs.

[mcolburn]

Pushed at 16:05 your time.

It usually takes 2-5 minutes to be available to OLW. The push I make triggers netlify to republish the site accessed at https://books.liml.org. OLW reads it, as well as the GOA DCS, to list available books and services.

On Aug 2, 2023, at 7:55 AM, Paul Vickers @.***> wrote:

Thanks again. I've pushed what I hope is the final index.html to the repo. I decided to replace all Choir IDs with People IDs.

— Reply to this email directly, view it on GitHub https://github.com/mcolburn/durham/issues/77#issuecomment-1662364170, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFXSKZ3V2YWRHVJOMKSKTXTJS6ZANCNFSM6AAAAAA26XV4IU. You are receiving this because you commented.

[paulvickers]

Perfect, thanks! I'll close this issue now.