mcolburn / durham

0 stars 0 forks source link

Missing rubrical in generated service book #79

Closed paulvickers closed 1 year ago

paulvickers commented 1 year ago

Lines 801–805 of index.html contain the following:

<!-- Then on all days rubric PV 20230225 -->
<tr>
<td class='leftCell'><p class='mixed'><span class='rubric'><span class='kvp' data-key='pub.priest.servicebook_gr_GR_cog|li.rubric.alldays'>Εἶτα κατὰ <span class='boldred'>πᾶσαν</span> Λειτουργἰαν· </span>
</span></p></td>
<td class='rightCell'><p class='mixed'><span class='rubric'><span class='kvp' data-key='pub.priest.servicebook_en_UK_durlash|li.rubric.alldays'>Then, on <span class='boldred'>all</span> days:</span></span>
</p></td>

This creates a rubrical 'Then, on all days:'. I can see this when editing in both the the en_uk_durlash: Screenshot 2023-08-08 at 15 58 22

And in the Romanian ro_uk_dur: Screenshot 2023-08-08 at 15 58 43

But when I generate the service book this directive is missing: Screenshot 2023-08-08 at 15 58 33

Could this be because there is no corresponding directive in any other English version in the database?

paulvickers commented 1 year ago

Nevermind. It appears to be there now. Possibly because I found a mismatched kvp in a left and right cell further down?

mcolburn commented 1 year ago

The problem appears to be that the generated html has another span embedded where the text of the rubric appears.

image

This happens for Greek, English, and the Romanian:

Pasted Graphic 1

I have checked and there is no key called y.m.d.md.

The only thing I can think of is that the generator is trying to compute a lookup key. The keys in the topic calendar are values such as y2018.m01.d02.ymd. Even if the generator is trying to compute a key and returning it without numbers, it would be y.m.d.ymd not y.m.d.md.

The only way to solve this issue is to fire up the dev environment and turn on the debugger.

paulvickers commented 1 year ago

That's weird, as that's not something I've added to the service. It's not a deal breaker as I can just add it to the generated .tex file post hoc.

mcolburn commented 1 year ago

Warning -- I found the bug and I am about to restart OLW.

mcolburn commented 1 year ago

I pushed the fix and restarted the server.

Now when I generate, I get this:

image

Please verify and close. Thanks!

paulvickers commented 1 year ago

Thanks!

mcolburn commented 1 year ago

Glad to help!

On Aug 8, 2023, at 3:24 PM, Paul Vickers @.***> wrote:

Closed #79 https://github.com/mcolburn/durham/issues/79 as completed.

— Reply to this email directly, view it on GitHub https://github.com/mcolburn/durham/issues/79#event-10040655036, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKFXSOPWZKEJHP3QQ2S6O3XUK4C5ANCNFSM6AAAAAA3IT4SRY. You are receiving this because you commented.