mcollera / AccessControlDsc

MIT License
13 stars 12 forks source link

Changes NTFSAccessEntry permission inheritance to be explicitly set #36

Open rcarpenter79 opened 6 years ago

rcarpenter79 commented 6 years ago

Resolves #35

I found some other problems when I was testing.

Fixed a problem when the folder owner was not System or a built-in group that causes the error "The security identifier is not allowed to be the owner of this object". Fixed a bug that caused the Test to report empty values for absent rules to remove and rules to be removed. Fixed a bug in Update-FileSystemRightsMapping that would add an additional phantom ACE when an inherited ACE had a permissions that used the generic permissions. Fixed a bug in Set-TargetResource caused by $Expected not being initialised. Fixed a bug where removing rules was causing changes to the remaining rules for that Identity. Switched from using RemoveAccessRule to RemoveAccessRuleSpecific.

codecov-io commented 6 years ago

Codecov Report

Merging #36 into Dev will increase coverage by <1%. The diff coverage is 91%.

Impacted file tree graph

@@        Coverage Diff         @@
##           Dev   #36    +/-   ##
==================================
+ Coverage   53%   53%   +<1%     
==================================
  Files        5     5            
  Lines      959   965     +6     
==================================
+ Hits       510   517     +7     
+ Misses     449   448     -1