mcollera / AccessControlDsc

MIT License

13 stars 12 forks source link

Changes RegistryAccessEntry to correctly remove specific ACEs from ACLs and gracefully handle the App Packages Principal, Issues #37 and #38 #39

Closed bcwilhite closed 5 years ago

bcwilhite commented 5 years ago

This PR addresses issues highlighted in https://github.com/mcollera/AccessControlDsc/issues/37 and https://github.com/mcollera/AccessControlDsc/issues/38

Modified RemoveAccessRule to RemoveAccessRuleSpecific to address specific Access Rule Removal. Also, created a function to create a SID Access Rule when the App Packages and other principals fail to resolve correctly.

codecov-io commented 5 years ago

Codecov Report

Merging #39 into Dev will increase coverage by 1%. The diff coverage is 83%.

@@        Coverage Diff        @@
##           Dev   #39   +/-   ##
=================================
+ Coverage   53%   54%   +1%     
=================================
  Files        5     5           
  Lines      959   996   +37     
=================================
+ Hits       510   543   +33     
- Misses     449   453    +4