mcollera / AccessControlDsc

MIT License

13 stars 12 forks source link

File system audit rule #54

Closed jcwalker closed 5 years ago

jcwalker commented 5 years ago

Added DSC resource FileSystemAuditRuleEntry

This change is

codecov-io commented 5 years ago

Codecov Report

Merging #54 into Dev will increase coverage by 5%. The diff coverage is 88%.

@@         Coverage Diff         @@
##           Dev    #54    +/-   ##
===================================
+ Coverage   54%    60%    +5%     
===================================
  Files        5      6     +1     
  Lines      968   1169   +201     
===================================
+ Hits       532    706   +174     
- Misses     436    463    +27

jcwalker commented 5 years ago

DscResources/FileSystemAuditRuleEntry/FileSystemAuditRuleEntry.psm1, line 55 at r4 (raw file):

Previously, chasewilson (Chase Wilson) wrote…

> ``` > $message = $localizedData.AclFound -f $inputPath > ``` Is there a reason to create a new var you aren't going to reuse or just recreate. Same goes for the next one

Is this hurting anything? The rest of the module is written in this fashion.

jcwalker commented 5 years ago

DscResources/FileSystemAuditRuleEntry/FileSystemAuditRuleEntry.psm1, line 55 at r4 (raw file):

Previously, jcwalker (Jason Walker) wrote…

Is this hurting anything? The rest of the module is written in this fashion.

Done.

jcwalker commented 5 years ago

DscResources/FileSystemAuditRuleEntry/FileSystemAuditRuleEntry.psm1, line 30 at r4 (raw file):

Previously, chasewilson (Chase Wilson) wrote…

> ``` > function Get-TargetResource > ``` These functions still don't have help sections.

Done.