mcollina / async-cache-dedupe

Async cache with dedupe support
MIT License
640 stars 40 forks source link

feat: use storage and invalidation #7

Closed simone-sanfratello closed 2 years ago

simone-sanfratello commented 3 years ago

proposal for use of an external storage, with optional invalidation


TODO

simone-sanfratello commented 3 years ago

still have to write test on storage and reach 100% coverage

mcollina commented 3 years ago

great work!

simone-sanfratello commented 3 years ago

I'm collecting on top all the points still have to work a lot on redis :) and on gc

simone-sanfratello commented 2 years ago

@mcollina wait to review, still a wip

mcollina commented 2 years ago

looks good!

simone-sanfratello commented 2 years ago

This needs lots of docs, specifically how to use references

I'm thinking of doing am extended use case in mercurius/cache and link there for documentation, for 2 reason: it's hard to explain references talking with abstractions, and the result of documentation here would be very close to the mercurius/cache one

wdyt?

mcollina commented 2 years ago

Just do one and copy it over/adapt here. I think this deserves some docs anyway.

simone-sanfratello commented 2 years ago

@mcollina apart of documentation, the code is done there are some points in the code marked with TODO, we can probably check them later I'm writing doc for mercurius-cache for references and invalidation, then I'll port here

simone-sanfratello commented 2 years ago

@mcollina done!