Exact matching - Githubissues

mcollina / bloomrun

A js pattern matcher

MIT License

120 stars 10 forks source link

Exact matching #19

Closed mcollina closed 8 years ago

mcollina commented 8 years ago

This needs a MAJOR bump.

Fixes #18.

@mcdonnelldean please test and review with your modules.

Not sure if we want to keep "partial" matching for list, it might be a cool feature to have.

mcdonnelldean commented 8 years ago

@mcollina Ok this looks good, I'm going to go ahead and accept but I agree about the partial matching.

What I would like to see is a flag that allows:

full match only
partial match if full match is not found
partial match always

What do you think?

mcollina commented 8 years ago

the "partial match is not found" is tricky, and I don't see any real feature for it. I would have the lookup being exact only, while I'd add a search method similar to list (or an option on list), that returns the partial matches, mainly for introspection.

mcdonnelldean commented 8 years ago

@mcollina Even better :D