search

mcollina / bloomrun

A js pattern matcher
MIT License
120 stars 10 forks source link

Remove functionality #7

Closed mcdonnelldean closed 9 years ago

mcdonnelldean commented 9 years ago

@mcollina Can you review please? Particularly for any side effects to the filters?

I also went back to the original test style since it matches with all of your other repositories.

mcollina commented 9 years ago

Apart from the two little notes, it's all good.

mcdonnelldean commented 9 years ago

@mcollina super I'll get these worked out tonight and re commit

mcdonnelldean commented 9 years ago

@mcollina Ok I've updated, I had to break out some functions, could you let me know if you want them anywhere else? For now I just popped them at the top of the file. I added extra tests too.