mcollina / heroku-buildpack-graphicsmagick

67 stars 77 forks source link

Get rid of vulcan dependency and recompile for both cedar and cedar-14 stacks #12

Closed benalavi closed 9 years ago

benalavi commented 9 years ago

Fixes #8, works w/ cedar & cedar-14 using Heroku STACK environment variable (https://devcenter.heroku.com/articles/buildpack-api#stacks) -- both builds will need to be compiled uploaded into the heroku-buildpacks-graphicsmagick bucket first due to the way it expects paths to be set up.

Can compile using VMs defined in Vagrantfile or on heroku using heroku run bash on a new cedar and cedar-14 stack.

The VM setup was helpful to me to more easily fix the issue, no problem to get rid of it.

mcollina commented 9 years ago

Can you please update the build instruction section, so that everybody knows how to build things?

Also, update the README and flag this as an OPEN Open Source module, if @paolochiodi is ok too. Follow this example (https://github.com/rvagg/node-levelup) and (https://github.com/mqttjs/MQTT.js).

I will send you an email with an IAM account that can be used to push to the main S3 repo.

mcollina commented 9 years ago

Also, write somewhere that you are the lead maintainer of this thing :)

paolochiodi commented 9 years ago

:+1:

Thank you @benalavi

benalavi commented 9 years ago

@mcollina @paolochiodi Sorry for the delay, been a busy week! Updated the README, merged this and verified that buildpack is now working on both cedar and cedar-14, will clean up the related issues.

mcollina commented 9 years ago

Thanks so much!! :dancers: